Skip to content

Customize the left and right buttons - #20888

Closed
n-for-all wants to merge 1 commit into
react:masterfrom
n-for-all:patch-4
Closed

Customize the left and right buttons#20888
n-for-all wants to merge 1 commit into
react:masterfrom
n-for-all:patch-4

Conversation

@n-for-all

@n-for-all n-for-all commented Aug 28, 2018

Copy link
Copy Markdown

Allow adding icon and text together for left and right buttons in the NavigatorIOS

Naji Amer
Customize the left and right buttons
3bf7d26 
allow adding icon and text together for left and right buttons
@n-for-all
n-for-all requested a review from shergin as a code owner August 28, 2018 11:48
@facebook-github-bot

ghost commented Aug 28, 2018

Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot

ghost commented Aug 28, 2018

Copy link
Copy Markdown
Warnings
⚠️

📋 Test Plan - This PR appears to be missing a Test Plan.
⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2018
@facebook-github-bot

ghost commented Aug 28, 2018

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@react-native-bot react-native-bot added Missing Test Plan This PR appears to be missing a test plan. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Aug 28, 2018
@elicwhite

ghost commented Sep 7, 2018

Copy link
Copy Markdown
Contributor

NavigatorIOS is deprecated and will be removed in a future release. We’d recommend moving to a better supported navigation system for React Native. Check out the navigation page of the docs for more info.

@elicwhite elicwhite closed this Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shergin shergin Awaiting requested review from shergin

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. Missing Test Plan This PR appears to be missing a test plan.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@n-for-all @facebook-github-bot @pull-bot @elicwhite @react-native-bot